Merged
Conversation
This should fix the duplicate documentation of "usage" in ModelArray by separating the class and function roxygen.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
- Coverage 89.51% 89.34% -0.18%
==========================================
Files 6 6
Lines 1717 1989 +272
==========================================
+ Hits 1537 1777 +240
- Misses 180 212 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add markdown rendering for roxygen
mattcieslak
reviewed
Apr 1, 2026
R/merge.R
Outdated
| #' head(merged$phenotypes) | ||
| #' | ||
| #' results <- ModelArray.lm( | ||
| #' FD ~ age + sex, |
Contributor
There was a problem hiding this comment.
Suggested change
| #' FD ~ age + sex, | |
| #' FD ~ age + FC + sex, |
mattcieslak
reviewed
Apr 1, 2026
R/merge.R
Outdated
| #' FD ~ age + sex, | ||
| #' data = merged$data, | ||
| #' phenotypes = merged$phenotypes, | ||
| #' scalar = "FD" |
Contributor
There was a problem hiding this comment.
Does this need to be scalar = c("FD", "FC")?
Collaborator
Author
There was a problem hiding this comment.
Yes. Probably makes more sense.
mattcieslak
reviewed
Apr 1, 2026
Contributor
mattcieslak
left a comment
mattcieslak
left a comment
There was a problem hiding this comment.
This is a HUGE improvement! Just a few minor comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the
roxygencomments don't render correctly so this should hopefully fix this.